-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dev docs #745
Merged
Merged
Update dev docs #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
amanji
reviewed
Aug 3, 2023
Deployment URLs ready for review. |
Signed-off-by: Gavin <[email protected]>
Co-authored-by: Akiff Manji <[email protected]> Signed-off-by: Gavin <[email protected]>
Gavinok
force-pushed
the
update-dev-docs
branch
from
August 3, 2023 20:17
1a1ea3e
to
33a2437
Compare
esune
reviewed
Aug 8, 2023
loneil
reviewed
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this checks out to me once Emiliano's question is resolved.
Should consider what to do about instructional setup videos in the future.
Signed-off-by: Gavin <[email protected]>
esune
approved these changes
Aug 9, 2023
loneil
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #612 excluding the documentation of ngrok (as it appears already to be done) and updating the USE-CASE-ONBOARD.md videos as they likely all need to be updated to the current state of traction.
In
https://github.com/bcgov/traction/tree/develop/services/tenant-ui#internationalization
add some details (link to a readme in the appropriate folder?) about
using the scripts Akiff developed for filling things in etc.
Move UX documents to a subfolder in
https://github.com/bcgov/traction/tree/develop/services/tenant-ui/docs. Or
check with Emiliano if they are appropriate to have in the
repository (or should move to other storage)
Determine if we want to add more videos/need to adjust existing to
the
https://github.com/bcgov/traction/blob/develop/docs/USE-CASE-ONBOARD.md
document. Also if those videos should be hosted elsewhere
(YouTube?). Check with Emiliano. If any action on that, create a new
ticket.
Documentation on ngrok usage in Docker scripts for Traction
ngrok
auth token and prevent the tunnels from expiring, add the value in the.env
file after uncommenting the line definingNGROK_AUTHTOKEN
and then start the project withdocker compose up
.Documentation on email mock image that can be used locally and how
to use it